ci: change triggers to prevent dual runs on prs #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clintonsteiner
commented
Apr 15, 2025
clintonsteiner
commented
- runs on pushes to master or prs to master
- will prevent action from running for the push in pr and pull request into master
* runs on pushes to master or prs to master * will prevent action from running for the push in pr and pull request into master
|
Personally, I'd recommend disallowing topic branches upstream via branch rulesets and forcing them into forks. This would solve said problem while still allowing branches in forks to be tested on pushes. |
|
Tests and checks are fast, about 2 minutes. The slow actions (wheels, s390x tests) are only run on push to the master branch. I don't see this to be much of a problem, do I miss something? |
|
@jdavid this also only affects PRs from upstream, not forks. But in general, it's a good organizational decision to separate topic branches to they don't collect dust upstream. |
2bndy5
added a commit
to 2bndy5/pygit2
that referenced
this pull request
Oct 14, 2025
2bndy5
added a commit
to 2bndy5/pygit2
that referenced
this pull request
Oct 14, 2025
per request from libgit2#1432 (comment) closes libgit2#1366 ### Changes - remove all test jobs from test.yml workflow except the one that runs on s390x platform. - rename the test.yml Display name accordingly: "Tests (s390x)" - skip building ppc64le wheels when not triggered on master branch. - reconfigure wheels.yml workflow triggers. The wheels.yml CI now runs for 1. any push to master branch 2. any change in a PR that targets master branch (excluding when PR changes only affect docs/ path) 3. any tag (starting with "v") is pushed - added `skip-existing` param in case deployment to PyPI suffers a network error and the CI just needs to be re-run. - cherry pick changes from PR libgit2#1366 (about CI triggers for lint and spell-check CI workflows) - auto-cancel wheels CI if new run triggered on non-default branch - added step to job that deploys wheels to PyPI. This new step creates a GitHub Release for the tag that was pushed.
2bndy5
added a commit
to 2bndy5/pygit2
that referenced
this pull request
Oct 15, 2025
per request from libgit2#1432 (comment) closes libgit2#1366 ### Changes - remove all test jobs from test.yml workflow except the one that runs on s390x platform. - rename the test.yml Display name accordingly: "Tests (s390x)" - skip building ppc64le wheels when not triggered on master branch. - reconfigure wheels.yml workflow triggers. The wheels.yml CI now runs for 1. any push to master branch 2. any change in a PR that targets master branch (excluding when PR changes only affect docs/ path) 3. any tag (starting with "v") is pushed - added `skip-existing` param in case deployment to PyPI suffers a network error and the CI just needs to be re-run. - cherry pick changes from PR libgit2#1366 (about CI triggers for lint and spell-check CI workflows) - auto-cancel wheels CI if new run triggered on non-default branch - added step to job that deploys wheels to PyPI. This new step creates a GitHub Release for the tag that was pushed.
2bndy5
added a commit
to 2bndy5/pygit2
that referenced
this pull request
Oct 15, 2025
per request from libgit2#1432 (comment) closes libgit2#1366 ### Changes - remove all test jobs from test.yml workflow except the one that runs on s390x platform. - rename the test.yml Display name accordingly: "Tests (s390x)" - skip building ppc64le wheels when not triggered on master branch. - reconfigure wheels.yml workflow triggers. The wheels.yml CI now runs for 1. any push to master branch 2. any change in a PR that targets master branch (excluding when PR changes only affect docs/ path) 3. any tag (starting with "v") is pushed - added `skip-existing` param in case deployment to PyPI suffers a network error and the CI just needs to be re-run. - cherry pick changes from PR libgit2#1366 (about CI triggers for lint and spell-check CI workflows) - auto-cancel wheels CI if new run triggered on non-default branch - use pytest.ini in cibuildwheel isolated env - added step to job that deploys wheels to PyPI. This new step creates a GitHub Release for the tag that was pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.